Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to DEV: Updating purchase event DL with new requirements #252

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

pgilmore-phi
Copy link
Collaborator

@pgilmore-phi pgilmore-phi commented Oct 22, 2024

Jira Ticket

PM-618

Purpose

Membership Cart (US and CA): On a completed order, update DL with order details

Changes

Updating existing DL with new requirements, adding items array containing each pet membership

Validate Changes

Complete and order, in Dev Tools open and view the data layer to validate all data exists as set out in the ticket

Before: https://develop--24petwatch--hlxsites.hlx.page/thank-you
After: https://feature-pm-618-dl-modifications--24petwatch--hlxsites.hlx.page/thank-you

Copy link

aem-code-sync bot commented Oct 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 22, 2024

Page Scores Audits Google
📱 /thank-you PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /thank-you PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to feature/PM-618-DL-modifications October 22, 2024 22:59 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/PM-618-DL-modifications October 23, 2024 13:43 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/PM-618-DL-modifications October 23, 2024 15:06 Inactive
Copy link
Collaborator

@hero-dokane hero-dokane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hero-dokane hero-dokane merged commit 2d02414 into develop Oct 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants