Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to sprint deploy: Added condition to load paid blog header fragment on paid blog template #247

Merged

Conversation

pgilmore-phi
Copy link
Collaborator

Added 2 new fragments for header:

fragments > us> header-paid-blog
fragments > ca > header-paid-blog
The new header fragment will be used on any page using Template : paid-blog-page

“Get Started” CTA on the paid blog template should go to: /lost-pet-protection/membership
“Get Started” CTA on the paid pages should go to: /lost-pet-protection/lps-quote

paid page: https://feature-pm-556-paid-blog-header--24petwatch--hlxsites.hlx.page/paid/membership
Paid blog page: https://feature-pm-556-paid-blog-header--24petwatch--hlxsites.hlx.page/paid-blog-page

Fix #PM-556

Test URLs:

Before: https://release-sprint-22-deploy--24petwatch--hlxsites.hlx.page/paid-blog-page
After: https://feature-pm-556-paid-blog-header--24petwatch--hlxsites.hlx.page/paid-blog-page

Copy link

aem-code-sync bot commented Oct 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Oct 21, 2024

Page Scores Audits Google
📱 /paid-blog-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /paid-blog-page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
📱 /paid/membership PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /paid/membership PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@pgilmore-phi pgilmore-phi changed the title Added condition to load paid blog header fragment on paid blog template Sync to sprint deploy: Added condition to load paid blog header fragment on paid blog template Oct 21, 2024
Copy link
Collaborator

@hero-dokane hero-dokane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pgilmore-phi pgilmore-phi merged commit 6d53e67 into release/sprint-22-deploy Oct 21, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants