Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ModLinks.xml #1243

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Update ModLinks.xml #1243

merged 2 commits into from
Jan 14, 2024

Conversation

ChouchIsCool
Copy link
Contributor

Tried to add new mod, Stop Hitting Yourself. I believe everything should be okay, as I tried looking at other mods' xml manifests, but I had not done this before, so there could still be errors.

Tried to add new mod, Stop Hitting Yourself I believe everything should be okay, as I tried looking at other mods' xml manifests, but I had not done so before, so there could be errors.
@flibber-hk
Copy link
Collaborator

flibber-hk commented Jan 12, 2024

It seems that your repo doesn't contain the source code but just a build of the mod - typically people upload the source code in the repository and make a release which contains the dll (or, more often, a zip containing the dll and pdb, which means that bug reports are more helpful)

(It's an unofficial rule that mods should be open-source)

@ChouchIsCool
Copy link
Contributor Author

Source code added (i hope that's all of it).
Makes sense mods should be open source.
thanks for the help

@SFGrenade SFGrenade self-assigned this Jan 14, 2024
@SFGrenade SFGrenade merged commit 53a07fb into hk-modding:main Jan 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants