Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a bug in saving the fallback model of an AI Route #417

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jan 24, 2025

Ⅰ. Describe what this PR did

Fix the bug that the fallback model of an AI Route cannot be saved.

Ⅱ. Does this pull request fix one issue?

fixes #415

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni January 24, 2025 02:08
@CH3CHO CH3CHO requested a review from songpengyuan as a code owner January 24, 2025 02:08
@CH3CHO CH3CHO force-pushed the fix/ai-route-fallback-model branch from 3c8f529 to 0d86add Compare January 24, 2025 02:09
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit f038c5e into higress-group:main Jan 24, 2025
4 checks passed
@CH3CHO CH3CHO deleted the fix/ai-route-fallback-model branch January 24, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI fallback configuration save failed
2 participants