Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18964 Remove obsolete JtaPlatforms #9607

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Jan 10, 2025

As suggested by @sebersole, this PR removes support for SAP NetWeaver and Bitronix.

But surely this is just a start. Looks like we can remove a few more.

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18964

@gavinking
Copy link
Member Author

Everyone: do we need to rescue any of these????

@scottmarlow
Copy link
Member

+1 as removing implementations that no longer are moving forward to new Persistence Spec versions looks right to me.

@gavinking
Copy link
Member Author

gavinking commented Jan 11, 2025

Looks like we should rescue SunOneJtaPlatform (but rename it) since that's apparently what people use in Payara: https://blog.payara.fish/use-hibernate-as-a-jpa-provider-with-payara

(And Glassfish too.)

@gavinking
Copy link
Member Author

@scottmarlow Which implementation of JtaPlatform is used in WildFly?

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jan 11, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [e51e41a, 5e2a0f7]

› This message was automatically generated.

@beikov
Copy link
Member

beikov commented Jan 21, 2025

It seems like some WebSphere platforms could be removed as well, since IBM WebSphere Liberty (the Jakarta version) is based on IBM OpenLiberty.

AFAIU, this means WebSphereExtendedJtaPlatform and WebSphereJtaPlatform are unnecessary.

@gavinking
Copy link
Member Author

It seems like some WebSphere platforms could be removed as well

Yes, I know. One of the reasons I had not merged this yet is I wanted to check this with @ebullient.

@ebullient
Copy link
Contributor

cc: @NottyCode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants