Add option to skip messages when a user joins/leaves a channel #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volker-fr
commented
Jan 16, 2025
| @click.option("--template", default=None, type=click.File('r'), help="Custom single file export template") | ||
| @click.argument('archive_dir') | ||
| @click.argument('archive') |
There was a problem hiding this comment.
this rename is to have the same config['archive'] name as main.py. This way the same config variable can be used in the Reader class.
volker-fr
commented
Jan 18, 2025
| @@ -112,27 +114,3 @@ def create_archive_info(filepath, extracted_path, archive_sha=None): | |||
| s = json.dumps(archive_info, ensure_ascii=False) | |||
| s = to_unicode(s) | |||
| f.write(s) | |||
|
|
|||
|
|
|||
| def get_export_info(archive_name): | |||
There was a problem hiding this comment.
This was only used by cli.py. At the same time the workspace name is also computed in Reader()
volker-fr
changed the title
|
@hfaran merge conflict got fixed. |
hfaran
requested changes
Jan 18, 2025
hfaran
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature flag to hide messages when a user joins/leaves a channel.
This PR also changes how config options handed over by click. Instead of having to add each new arg in a list, it automatically hands them over in an config dict. As result the way how these configs are set had to be changes where they are used.
This PR also moves the zip file extraction to the Reader class. The reason is that cli.py and main.py had separate extract options. At the same time, cli.py used the unzip function to generate the slack name, which also needs to be computed in the Reader class itself.
PR resolves also #191