Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message shown for legacy Celery #1718

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Dec 11, 2024

pip 24.1+ rejects packages that use invalid versions in their metadata (such as Celery older than v5.2.1).

We now annotate such failures with additional help text, mentioning the package needs to be upgraded, and link to the changelog entry which has additional advice:
https://devcenter.heroku.com/changelog-items/3073

This will help give clues to users who haven't seen the changelog entry (as seen in a couple of recent support tickets).

See also:
#1685 (comment)

GUS-W-17415804.

pip 24.1+ rejects packages that use invalid versions in their metadata
(such as Celery older than v5.2.1).

We now annotate such failures with additional help text, mentioning
the package needs to be upgraded, and link to the changelog entry
which has additional advice:
https://devcenter.heroku.com/changelog-items/3073

GUS-W-17415804.
@edmorley edmorley self-assigned this Dec 11, 2024
@edmorley edmorley marked this pull request as ready for review December 11, 2024 19:06
@edmorley edmorley requested a review from a team as a code owner December 11, 2024 19:06
@edmorley edmorley enabled auto-merge (squash) December 12, 2024 16:01
@edmorley edmorley merged commit c4e4a4f into main Dec 12, 2024
8 checks passed
@edmorley edmorley deleted the pip-legacy-celery branch December 12, 2024 16:06
@heroku-linguist heroku-linguist bot mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants