Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the EOL Python error messaging #1570

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

edmorley
Copy link
Member

For cases where a requested Python version is both (a) EOL, and (b) was never built for that stack (such as is the case when we add new stacks), previously the generic "version isn't available for this stack" error message was shown instead of the more specific EOL Python version error message.

Now, the EOL version check is performed first before the S3 presence check, so the more specific EOL message is shown for this case.

In addition to improving the UX, making this change now reduces the test fixture churn both when we add a new stack and for #1567.

I've also dropped the "PyPy is no longer supported" error message and associated test, since very few apps ever used it and it's now been 19 months since support was removed in #1364, so it's fine to show the generic "Python version isn't available" error message for it instead.

GUS-W-15541279.

@edmorley edmorley self-assigned this Apr 18, 2024
@edmorley edmorley marked this pull request as ready for review April 18, 2024 09:51
@edmorley edmorley requested a review from a team as a code owner April 18, 2024 09:51
Copy link
Contributor

@dzuelke dzuelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to look up the extglob pattern repetition syntax there ;)

For cases where a requested Python version is both (a) EOL, and (b) was
never built for that stack (such as is the case when we add new stacks),
previously the generic "version isn't available for this stack" error
message was shown instead of the more specific EOL Python version error
message.

Now, the EOL version check is performed first before the S3 presence
check, so the more specific EOL message is shown for this case.

In addition to improving the UX, making this change now reduces the
test fixture churn both when we add a new stack and for #1567.

I've also dropped the "PyPy is no longer supported" error message
and associated test, since very few apps ever used it and it's now been
19 months since support was removed in #1364, so it's fine to show the
generic "Python version isn't available" error message for it instead.

GUS-W-15541279.
@edmorley edmorley force-pushed the improved-eol-error-messages branch from acb5259 to b04f3eb Compare April 18, 2024 15:46
@edmorley edmorley enabled auto-merge (squash) April 18, 2024 15:46
@edmorley edmorley merged commit 42d1ba2 into main Apr 18, 2024
5 checks passed
@edmorley edmorley deleted the improved-eol-error-messages branch April 18, 2024 15:48
@heroku-linguist heroku-linguist bot mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants