Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(W-17568149): pg:settings:log-min-duration-statement command is su… #3167

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

justinwilaby
Copy link
Contributor

This PR addresses 2 issues:

  1. fix(W-17568149): pg:settings:log-min-duration-statement command is submitting a string instead of number

› Error: The value for log_min_duration_statement needs to be a number
› Error ID: bad_request

  1. fix(W-17414774): Triage credential scan results for https://github.com/heroku/cli

The latter was a never a security issue but the text was changed anyway so as not to trigger further false alarms.

Test

  1. heroku pg:settings:log-min-duration-statement -a <your app> <your db> 3000
  2. Observe the error is no longer present

…bmitting a string instead of number

fix(W-17414774): Triage credential scan results for https://github.com/heroku/cli
@justinwilaby justinwilaby requested a review from a team as a code owner January 9, 2025 18:04
@justinwilaby justinwilaby merged commit d645f0e into main Jan 9, 2025
8 checks passed
@justinwilaby justinwilaby deleted the fix/pg-settings branch January 9, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants