tbcd: move block header cache from items to size #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
requested changes
Jan 8, 2025
joshuasing
changed the title
ClaytonNorthey92
requested changes
Jan 8, 2025
ClaytonNorthey92
approved these changes
Jan 8, 2025
joshuasing
reviewed
Jan 9, 2025
joshuasing
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We really should use size as the metric to determine cache size. This flips that for blockheaders.
Changes
This fixes a major bug in headers only mode where headers were not purged from the cache. This may have caused problems we had not diagnosed.