Return error when attempting to serialize an empty path #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #278 (comment), this PR returns an error code when an empty
FlexPathis detected during serialization or when generating polygons. For Python callers, aRuntimeWarningis raised, matching what occurs when missing references or invalid repetitions are encountered.Because the tolerance value is stored internally to each
FlexPaththough, writing a path to a library with aprecisionvalue which is too large to represent that path does not generate an error code or warning. Callers will still need to be cautious when copying objects between libraries with differingprecisions.