-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for header-only compile actions by Bazel #219
base: main
Are you sure you want to change the base?
Fix for header-only compile actions by Bazel #219
Conversation
Is ready to be committed? Can someone please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this ready to be merged? We are running into the same issue... |
This worked fine to produce a compilation database on a Abseil library. But I had to patch the |
@cpsauer could you take a look at this when you have a chance? It would be great to finally get this merged. Thanks in advance. |
Fix for header-only compile actions by Bazel
This PR fixes, as far as I can tell, the issues related to #199 where Bazel adds header-only / syntax-only compilation actions that produce dummy output files (.processed). I believe this is part of Bazel open-sourcing more of its capabilities for preprocessing headers and handling pre-compiled modules.
The fix is based on #209 and makes the following changes:
This fix was tested in this repo: https://github.com/mikael-s-persson/evdevpp
And also tested and used for a while in other private repos.
This seems to produce clean, non-racy outputs. AFAICT, the resulting
compile_commands.json
file contains everything it should, including the headers.Fixes #199