Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added configurable password validation #7640

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

dakshesh14
Copy link
Contributor

@dakshesh14 dakshesh14 commented Jan 11, 2025

Feature:

  • Introduced configurable password validation rules.
  • Validation rules can be customized or completely disabled through config.json, ensuring flexibility.

Demo:
The following demo uses password=false for easier visibility while typing:

password-validation.webm

Copy link

Connected to Huly®: UBERF-9112

@dakshesh14
Copy link
Contributor Author

Note: I noticed that similar PRs were previously raised about six months ago but did not address review feedback and lacked configurability. This PR aims to address those gaps with a more flexible and reusable implementation.

@haiodo haiodo requested a review from aonnikov January 14, 2025 05:14
aonnikov
aonnikov previously approved these changes Jan 15, 2025
Copy link
Member

@aonnikov aonnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add de translation

@aonnikov
Copy link
Member

@dakshesh14 sorry for long review. The PR looks good to me, I will merge it as soon as you resolve conflicts

@haiodo
Copy link
Member

haiodo commented Jan 16, 2025

Hi I think it is too much options for configuration, may be we could have just one option validation with few options like, none, strict? none will be for dev mode, and strict will add default verifications? Or we could think about ability to configure rules via passing some json config with all set of this rules passed.

@dakshesh14
Copy link
Contributor Author

Hi @haiodo, I agree—the current setup offers full configurability, but it might be overkill. I'll update it to only use 'PASSWORD_STRICT_MODE' and adjust the rest accordingly."

@dakshesh14
Copy link
Contributor Author

Hey @aonnikov @haiodo, I made the changes. Can you guys review it?

@dakshesh14 dakshesh14 requested a review from aonnikov January 18, 2025 17:20
@aonnikov
Copy link
Member

@dakshesh14 could you please resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants