-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added configurable password validation #7640
base: develop
Are you sure you want to change the base?
feat: added configurable password validation #7640
Conversation
Connected to Huly®: UBERF-9112 |
Note: I noticed that similar PRs were previously raised about six months ago but did not address review feedback and lacked configurability. This PR aims to address those gaps with a more flexible and reusable implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add de translation
@dakshesh14 sorry for long review. The PR looks good to me, I will merge it as soon as you resolve conflicts |
Hi I think it is too much options for configuration, may be we could have just one option validation with few options like, none, strict? none will be for dev mode, and strict will add default verifications? Or we could think about ability to configure rules via passing some json config with all set of this rules passed. |
Hi @haiodo, I agree—the current setup offers full configurability, but it might be overkill. I'll update it to only use 'PASSWORD_STRICT_MODE' and adjust the rest accordingly." |
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
0bb6c6b
to
3af8693
Compare
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
Signed-off-by: Dakshesh Jain <[email protected]>
@dakshesh14 could you please resolve conflicts? |
Signed-off-by: Dakshesh Jain <[email protected]>
Feature:
Demo:
The following demo uses password=false for easier visibility while typing:
password-validation.webm