Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update huly.nginx. Increased file upload size #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nginx/huly.nginx
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
server {
listen 80;
server_name _;
client_max_body_size 100M;
Copy link

@egavrilov egavrilov Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
client_max_body_size 100M;
client_max_body_size 0;

Might be even better to lift client_max_body_size and control it through the outer reverse proxy or host configuration, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use nginx as reverse proxy - so there is Huly and nginx in front. Had problems with attaching files to issues in Huly and increased the client_max_body_size

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be even better to lift client_max_body_size and control it through the outer reverse proxy or host configuration, what do you think?

Agree, if huly could control on own side (not checked yet, just started reading the docs)


location / {
proxy_set_header Host $host;
proxy_set_header X-Real-IP $remote_addr;
Expand Down Expand Up @@ -66,4 +68,4 @@ server {
rewrite ^/_rekoni(/.*)$ $1 break;
proxy_pass http://rekoni:4004/;
}
}
}