Fix test case for binding expression ranges #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a binding set, the `names` index is first, then a peek for `M`, then (M-1) parses of `line`/`col`/`name`. The old test code cases `DFGCAI` decodes to `-1`, `-2`, `3`, `1`, `0`, `4`. The `D` decodes the first param's unavailable expression. Then we move on to the second param's initial `names` index, which decodes `F` (`-2`). But `-2` is not a valid names index, it looks like we mixed the `M` and `names` order.
|
We've changed the spec to put the number of binding ranges before the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a binding set, the
namesindex is first, then a peek forM, then (M-1) parses ofline/col/name.The old test code cases
DFGCAIdecodes to-1,-2,3,1,0,4. TheDdecodes the first param's unavailable expression. Then we move on to the second param's initialnamesindex, which decodesF(-2). But-2is not a valid names index, it looks like we mixed theMandnamesorder.