Explicitly install OpenShift CLI tools as not included in latest GitHub Runner image [DI-396] #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub Runner image [DI-396] The latest GitHub `ubuntu-24.04` runner image [no longer includes the OpenShift CLI](actions/runner-images#10636), which has cause [unexpected action failures](https://github.com/hazelcast/hazelcast-docker/actions/runs/12684539163): `oc: command not found. Changes: - Explicitly install the OpenShift tools [(as per `hazelcast-platform-operator)](https://github.com/search?q=repo%3Ahazelcast%2Fhazelcast-platform-operator%20redhat-actions%2Fopenshift-tools-installer&type=code) - Replace explicit `oc login` command (requiring the `oc` binary) with cross-platform action Fixes: [DI-396](https://hazelcast.atlassian.net/browse/DI-396) Post-merge actions: - [ ] backport to maintenance branches
nishaatr
requested changes
Jan 9, 2025
nishaatr
approved these changes
Jan 9, 2025
ldziedziul
approved these changes
Jan 9, 2025
| PREFLIGHT_VERSION=$(curl -s https://api.github.com/repos/redhat-openshift-ecosystem/openshift-preflight/releases/latest | grep 'tag_name' | cut -d\" -f4) | ||
| wget https://github.com/redhat-openshift-ecosystem/openshift-preflight/releases/download/${PREFLIGHT_VERSION}/preflight-linux-amd64 | ||
| chmod +x preflight-linux-amd64 | ||
| - uses: redhat-actions/openshift-tools-installer@v1 |
JackPGreen
added a commit
that referenced
this pull request
Jan 9, 2025
…ub Runner image [DI-396] (#850) The latest GitHub `ubuntu-24.04` runner image [no longer includes the OpenShift CLI](actions/runner-images#10636), which has cause [unexpected action failures](https://github.com/hazelcast/hazelcast-docker/actions/runs/12684539163): `oc: command not found.` Changes: - Explicitly install the OpenShift tools [(as per `hazelcast-platform-operator`)](https://github.com/search?q=repo%3Ahazelcast%2Fhazelcast-platform-operator%20redhat-actions%2Fopenshift-tools-installer&type=code) - includes migrating `preflight` tool - Replace explicit `oc login` command with action Fixes: [DI-396](https://hazelcast.atlassian.net/browse/DI-396) [DI-396]: https://hazelcast.atlassian.net/browse/DI-396?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Jan 9, 2025
…ub Runner image [DI-396] (#850) The latest GitHub `ubuntu-24.04` runner image [no longer includes the OpenShift CLI](actions/runner-images#10636), which has cause [unexpected action failures](https://github.com/hazelcast/hazelcast-docker/actions/runs/12684539163): `oc: command not found.` Changes: - Explicitly install the OpenShift tools [(as per `hazelcast-platform-operator`)](https://github.com/search?q=repo%3Ahazelcast%2Fhazelcast-platform-operator%20redhat-actions%2Fopenshift-tools-installer&type=code) - includes migrating `preflight` tool - Replace explicit `oc login` command with action Fixes: [DI-396](https://hazelcast.atlassian.net/browse/DI-396) [DI-396]: https://hazelcast.atlassian.net/browse/DI-396?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
that referenced
this pull request
Jan 9, 2025
…ub Runner image [DI-396] (#850) The latest GitHub `ubuntu-24.04` runner image [no longer includes the OpenShift CLI](actions/runner-images#10636), which has cause [unexpected action failures](https://github.com/hazelcast/hazelcast-docker/actions/runs/12684539163): `oc: command not found.` Changes: - Explicitly install the OpenShift tools [(as per `hazelcast-platform-operator`)](https://github.com/search?q=repo%3Ahazelcast%2Fhazelcast-platform-operator%20redhat-actions%2Fopenshift-tools-installer&type=code) - includes migrating `preflight` tool - Replace explicit `oc login` command with action Fixes: [DI-396](https://hazelcast.atlassian.net/browse/DI-396) [DI-396]: https://hazelcast.atlassian.net/browse/DI-396?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest GitHub
ubuntu-24.04runner image no longer includes the OpenShift CLI, which has cause unexpected action failures:oc: command not found.Changes:
hazelcast-platform-operator)preflighttooloc logincommand with actionFixes: DI-396
Post-merge actions: