Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic when explaining native query and add NaN, Inf format settings #24

Merged
merged 5 commits into from
Oct 12, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Oct 11, 2024

  • Fix panic error when explaining native query
  • Add settings to transform NaN, +Inf, and -Inf values to default values

Copy link

github-actions bot commented Oct 11, 2024

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-prometheus/connector/api 69%
github.com/hasura/ndc-prometheus/connector/client 58%
github.com/hasura/ndc-prometheus/connector 55%
github.com/hasura/ndc-prometheus/connector/internal 56%
github.com/hasura/ndc-prometheus/connector/metadata 89%
github.com/hasura/ndc-prometheus/connector/types 100%
Summary 65% (2426 / 3752)

Minimum allowed line rate is 40%

@hgiasac hgiasac changed the title fix panic when explaining native query and fix NaN value encoder and decoder fix panic when explaining native query and add NaN, Inf format settings Oct 12, 2024
@hgiasac hgiasac merged commit 7a19117 into main Oct 12, 2024
1 check passed
@hgiasac hgiasac deleted the fix-native-query-explain-panic branch October 12, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant