Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate contents of ndc-hub #433

Conversation

scriptnull
Copy link
Member

@scriptnull scriptnull commented Jan 14, 2025

This PR introduces

  • a validate command in the registry-automation program
  • a GitHub action workflow that runs the validate command on every commit in the main branch and in pull requests

Additionally, I have made the CI checks to be needed for merging a PR.

@scriptnull scriptnull marked this pull request as ready for review January 14, 2025 08:47
@scriptnull scriptnull requested a review from codedmart January 14, 2025 08:47
@scriptnull
Copy link
Member Author

@codingkarthik @codedmart The validation errors here are causing trouble downstream with other services. So I am going for a merge on this one to set the base framework for adding more validations. Feel free to review when you find time and comment if you have concerns.

@scriptnull scriptnull merged commit 4ada5fd into main Jan 14, 2025
2 of 3 checks passed
@scriptnull scriptnull deleted the vishnu/cps-1485-add-ci-check-in-ndc-hub-to-validate-the-configurations branch January 14, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant