Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the CI build on Buildkite with GitHub Actions. #117

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

SamirTalwar
Copy link
Contributor

The GitHub Actions logs are public, just like this repository.

We don't need the Docker setup for GitHub Actions; rustup is enough.

The GitHub Actions logs are public, just like this repository.

We don't need the Docker setup for GitHub Actions; `rustup` is enough.
Copy link
Contributor

@hallettj hallettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there anything running tests in CI? I think --all-targets builds the test binary, but doesn't run it. Although I see there are only two tests in this repo at the moment.

@SamirTalwar
Copy link
Contributor Author

@hallettj: No, there isn't but I have a follow-up ready to go that adds that CI job.

@SamirTalwar SamirTalwar merged commit 9959ddf into main Mar 11, 2024
5 of 6 checks passed
@SamirTalwar SamirTalwar deleted the samirtalwar/drop-buildkite branch March 11, 2024 23:21
@SamirTalwar
Copy link
Contributor Author

Oh, my apologies, there is a cargo test job (example).

Nevertheless, #119 adds some improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants