Update to Elm 0.19. #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andys8
requested changes
Oct 10, 2018
client/Main.elm
Outdated
| import Html.Events exposing (..) | ||
| import Http | ||
| import Api exposing (..) | ||
| import Debug |
There was a problem hiding this comment.
Could you get rid of Debug since it is not allowed to be used in production code or published packages? In 0.19 there are only functions for numbers and toString has to be implemented by the user.
There was a problem hiding this comment.
I'll fix this up later tonight. I was just getting something minimally working, and know Debug got deprecated (and a good thing too!).
|
That's fast. Thanks a lot, @FranklinChen |
|
Looks like the |
|
Unfortunately, it's hard to test and view changes when the Elm code still doesn't compile because the generated |
Closed
Merged
|
#8 is based on the work done in this PR. Thanks @FranklinChen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #6 with the caveat that we are waiting on haskell-servant/servant-elm#44 for everything to fully work.