Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns_ptr_record_set resource #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jrandall
Copy link
Contributor

@jrandall jrandall commented Jun 3, 2020

Add a dns_ptr_record_set resource to manage PTR records as a set. With the existing dns_ptr_record, if there is an existing reverse DNS entry for an IP, terraform will add an additional one, and then get stuck not being able to work with the state because there are multiple PTR entries (it triggers the issue described in #93).

This adds a dns_ptr_record_set resource type as suggested by @bodgit in #93 (comment)

With this fix, setting the ptr record to a single element list will mean that terraform will remove any other extant entries and ensure that the listed entry is the only PTR record for the IP.

Theoretically, if someone wanted to manage multiple PTR records, this should also work for that -- I am not aware of a valid use-case for that, but since there are several DNS servers including the popular bind that allows that, it makes sense to manage the PTR records as a set.

Fixes #93

@ghost ghost added size/L labels Jun 3, 2020
@jrandall jrandall force-pushed the dns-ptr-record-set branch 2 times, most recently from 4a5b72c to 6d044dd Compare June 3, 2020 23:41
@ghost ghost added size/XL documentation and removed size/L labels Jun 3, 2020
@jrandall jrandall force-pushed the dns-ptr-record-set branch from e920c45 to 398f3d7 Compare June 3, 2020 23:46
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 22, 2020

CLA assistant check
All committers have signed the CLA.

Base automatically changed from master to main February 1, 2021 17:27
@verejoel
Copy link

Will there be any movement on this? Would be useful for me to get this added.

@jrandall
Copy link
Contributor Author

Apologies, I am working on getting permission to sign the CLA now.

@jrandall jrandall force-pushed the dns-ptr-record-set branch from 398f3d7 to 228939f Compare March 1, 2022 01:07
@jrandall jrandall requested a review from a team as a code owner March 1, 2022 01:07
@jrandall jrandall force-pushed the dns-ptr-record-set branch from 913db56 to b493e35 Compare March 1, 2022 01:12
@jrandall
Copy link
Contributor Author

jrandall commented Mar 2, 2022

@hashicorp-cla my employer would prefer to sign a corporate CLA rather than have me sign on their behalf (as they would need to authorise me to do that).

This possibility is mentioned in CLA clause 4:
"... or that your employer has executed a separate Corporate CLA with HashiCorp"

How can we go about executing a corporate CLA?

I see this has been asked (but no apparent answer is visible) elsewhere: https://discuss.hashicorp.com/t/corporate-cla-info/11397

@bookshelfdave
Copy link
Contributor

@jrandall if you email me at dave.parfitt at hashicorp dot com, I can help with the corporate CLA.

@p3kx
Copy link

p3kx commented Nov 21, 2023

Hello,
what is the current status?

I'm looking forward to this resource as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple PTR records are not handled gracefully
5 participants