Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framework: Add unknown value refinement acceptance tests #296

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

austinvalle
Copy link
Member

Ref: hashicorp/terraform-plugin-framework#1062
Ref: hashicorp/terraform-plugin-go#448
Ref: hashicorp/terraform-plugin-framework-validators#250

This PR adds acceptance tests for unknown value refinements, including:

  • Resource that produces unknown value refinements which allow previously failing configurations to pass successfully
  • Resource that consumes unknown value refinements to produce errors during plan (when all values are unknown)
  • Resource that produces an unknown value refinement, then doesn't honor that refinement promise (resulting in a data consistency error)

TODOs left on this PR

  • Design is still under review
  • Update to use released versions of terraform-plugin-go, terraform-plugin-framework, terraform-plugin-framework-validators, once that's ready

Comment on lines +8 to +12
github.com/hashicorp/terraform-plugin-framework v1.13.1-0.20250116190529-2e147507972f
github.com/hashicorp/terraform-plugin-framework-timeouts v0.5.0
github.com/hashicorp/terraform-plugin-framework-timetypes v0.5.0
github.com/hashicorp/terraform-plugin-go v0.25.0
github.com/hashicorp/terraform-plugin-framework-validators v0.16.1-0.20250116191909-1452aa1f60c0
github.com/hashicorp/terraform-plugin-go v0.25.1-0.20250116190359-f977ddce3f6c
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update with released versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant