feat: Report usage of write-only attributes for public providers #1926
+209
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
previously approved these changes
Jan 17, 2025
ansgarm
force-pushed
the
wip-collect-write-only-attributes
branch
from
410922d to
83e79a8
Compare
jpogran
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on
This PR adds a job that counts usages of write-only attributes. Currently the editor supports these but does not offer special handling in the case of ephemeral values (e.g. ephemeral values can be passed to write-only attributes but not to "normal" ones). By reporting telemetry of these we can learn about their usage in the wild and properly prioritize related features improving their usage.