Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update reference to community templates #179

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

lbajolet-hashicorp
Copy link
Contributor

The Community Templates link from the builder did not link to the community templates general documentation page, and instead was a broken link.

Closes #178

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner August 12, 2024 19:50
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should point to the developer portal, as packer.io is reserved fro marketing.

@@ -76,7 +76,7 @@ This is an example only, and will time out waiting for SSH because we have not
provided a kickstart file. You must add a valid kickstart file to the
"http_directory" and then provide the file in the "boot_command" in order for
this build to run. We recommend you check out the
[Community Templates](/community-tools#templates)
[Community Templates](https://packer.io/community-tools#templates)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Community Templates](https://packer.io/community-tools#templates)
[Community Templates](https://developer.hashicorp.com/packer/docs/community-tools#templates)

@@ -87,7 +87,7 @@ This is an example only, and will time out waiting for SSH because we have not
provided a kickstart file. You must add a valid kickstart file to the
"http_directory" and then provide the file in the "boot_command" in order for
this build to run. We recommend you check out the
[Community Templates](/community-tools#templates)
[Community Templates](https://packer.io/community-tools#templates)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Community Templates](https://packer.io/community-tools#templates)
[Community Templates](https://developer.hashicorp.com/packer/docs/community-tools#templates)

The Community Templates link from the builder did not link to the
community templates general documentation page, and instead was a broken
link.
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the fix_community_templates_link branch from ef20a85 to f6e5194 Compare August 12, 2024 21:06
@lbajolet-hashicorp
Copy link
Contributor Author

Good catch! Updated this now, I'll wait until the tests go green and merge.

@lbajolet-hashicorp lbajolet-hashicorp merged commit 5927a29 into main Aug 13, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix_community_templates_link branch August 13, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community Templates link broken
2 participants