Skip to content

Commit

Permalink
comment out diff cover
Browse files Browse the repository at this point in the history
remove socket
  • Loading branch information
kimpham54 committed Oct 17, 2024
1 parent 926fbf8 commit 42c3860
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 14 deletions.
26 changes: 13 additions & 13 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,18 @@ jobs:
- name: Fetch base branch
run: git fetch origin main

# Compare coverage with the base branch
- name: Compare coverage
run: |
pip install diff-cover
git checkout main
python -m coverage run -p -m pytest src/jp2_remediator/tests/unit
python -m coverage xml -o coverage-base.xml
git checkout -
python diff-cover --compare-branch=main coverage.xml
# # Compare coverage with the base branch
# - name: Compare coverage
# run: |
# pip install diff-cover
# git checkout main
# python -m coverage run -p -m pytest src/jp2_remediator/tests/unit
# python -m coverage xml -o coverage-base.xml
# git checkout -
# python diff-cover --compare-branch=main coverage.xml

# Fail if coverage decreases
- name: Fail if coverage decreases
run: |
python diff-cover --compare-branch=main coverage.xml --fail-under=100
# # Fail if coverage decreases
# - name: Fail if coverage decreases
# run: |
# python diff-cover --compare-branch=main coverage.xml --fail-under=100

1 change: 0 additions & 1 deletion src/jp2_remediator/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import logging
from logging.handlers import TimedRotatingFileHandler
import os
import socket
from datetime import datetime

LOG_FILE_BACKUP_COUNT = int(os.getenv('LOG_FILE_BACKUP_COUNT', '30'))
Expand Down

0 comments on commit 42c3860

Please sign in to comment.