Effective gas price #4759

Frozen · 2024-09-17T20:44:16Z

This PR address this issue by setting the effectiveGasPrice to the transaction gas price. It is not implementing the full EIP 1559.

EffectiveGasPricefield added to TxRusult. Added json and rlp serialization tests.

rpc/harmony/v2/types.go

sophoah · 2024-09-23T08:49:16Z

@Frozen During my test, effectiveGasPrice field in the transaction receipt is still not available. I checked eth_getTransactionReceipt and hmy_getTransactionReceipt

Please make sure the effectiveGasPrice is the same as the gasPrice

sophoah · 2024-09-30T08:27:28Z

@Frozen hmyv1 and v2 APIs has the hex vs decimal difference see below effectiveGasPrice in decimal vs cumulatedGasPrice in hex

{
  "transaction-hash": "0x6ce7fd454c5c3e642a4573bd684f28acaf5f5478dddf56f1ec64c8808b57190a",
  "blockchain-receipt": {
    "blockHash": "0xfacba8e14ccd7ae0e066df602b49251a09bccd510597fa8f5c17b0859df493f0",
    "blockNumber": "0x9",
    "contractAddress": "0x0000000000000000000000000000000000000000",
    "cumulativeGasUsed": "0x5208",
    "effectiveGasPrice": 100000000000,
    "from": "one1zksj3evekayy90xt4psrz8h6j2v3hla4qwz4ur",
    "gasUsed": "0x5208",
    "logs": [],
    "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
    "root": "0x",
    "shardID": 0,
    "status": "0x1",
    "to": "one19zzwsxr0uf2fe34y8qkadek2v0eh6h5mg2deg6",
    "transactionHash": "0x6ce7fd454c5c3e642a4573bd684f28acaf5f5478dddf56f1ec64c8808b57190a",
    "transactionIndex": "0x0"
  },
  "time-signed-utc": "2024-09-30 08:17:36.579582"
}

Also eth_getTransactionReceipt still doesn't have the field effectiveGasPrice

{
 "jsonrpc": "2.0",
 "id": 1,
 "result": {
   "blockHash": "0xfacba8e14ccd7ae0e066df602b49251a09bccd510597fa8f5c17b0859df493f0",
   "blockNumber": "0x9",
   "contractAddress": null,
   "cumulativeGasUsed": "0x5208",
   "from": "0x15a128e599b74842bccba860311efa92991bffb5",
   "gasUsed": "0x5208",
   "logs": [],
   "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
   "status": "0x1",
   "to": "0x2884e8186fe2549cc6a4382dd6e6ca63f37d5e9b",
   "transactionHash": "0xad611cd8342d244e74f64888309fdf819c23f308f425edbeee289492729ae47a",
   "transactionIndex": "0x0"
 }
}

Frozen · 2024-10-16T23:30:26Z

Fixed json hex view for effectiveGasPrice

  "cumulativeGasUsed": "0x5208",
  "effectiveGasPrice": "0x17480",

sophoah · 2024-10-17T09:17:50Z

eth_getTransactionReceipt and the blockchain receipt generated by the hmy command during a transfer works now.

Could you check hmy_getTransactionReceipt and hmyv2_getTransactionReceipt ? those would be the last ones that should require the field effectiveGasPrice

ChiTimesChi · 2025-01-08T19:01:44Z

@sophoah @Frozen is there an ETA for this PR to be completed? This is causing issues when trying to use foundry to interact with the harmony blockchain. It is my understanding that EffectiveGasPrice is a mandatory field in the latest spec.

foundry-rs/foundry#7640 (comment)

Frozen · 2025-01-08T23:53:34Z

it will be included in next release

sophoah · 2025-01-10T08:18:24Z

@Frozen hmy_getTransactionReceipt and hmy_getTransactionReceipt are good :
hmy:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "blockHash": "0x29e06a818eb40489e346b41717f4b4f314ec06a67d9cdb7e0f721be8667cc402",
    "blockNumber": "0x3",
    "contractAddress": "0x0000000000000000000000000000000000000000",
    "cumulativeGasUsed": "0x5208",
    "effectiveGasPrice": "0x174876e800",
    "from": "one1zksj3evekayy90xt4psrz8h6j2v3hla4qwz4ur",
    "gasUsed": "0x5208",
    "logs": [],
    "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
    "root": "0x",
    "shardID": 0,
    "status": "0x1",
    "to": "one1eenp9ujcrmyaq22ef6jrpry2k97tjz4xs6ppcf",
    "transactionHash": "0x54e5a487016f05fa402b314c1e1aac397163863842c1914c3a3511a77e0cc838",
    "transactionIndex": "0x0"
  }
}

eth:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "blockHash": "0x29e06a818eb40489e346b41717f4b4f314ec06a67d9cdb7e0f721be8667cc402",
    "blockNumber": "0x3",
    "contractAddress": null,
    "cumulativeGasUsed": "0x5208",
    "effectiveGasPrice": "0x174876e800",
    "from": "0x15a128e599b74842bccba860311efa92991bffb5",
    "gasUsed": "0x5208",
    "logs": [],
    "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
    "status": "0x1",
    "to": "0xce6612f2581ec9d029594ea4308c8ab17cb90aa6",
    "transactionHash": "0x50fbac1de6df537d569cd24f962f08986800bcd3939a41144a072b0dcb6a7674",
    "transactionIndex": "0x0"
  }
}

however hmyv2_getTransactionReceipt should return the result in decimal (non hex), it currently return an hex, see cumulativeGasUsed, gasUsed are in decimal below except effectiveGasPrice:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "blockHash": "0x29e06a818eb40489e346b41717f4b4f314ec06a67d9cdb7e0f721be8667cc402",
    "blockNumber": 3,
    "contractAddress": "0x0000000000000000000000000000000000000000",
    "cumulativeGasUsed": 21000,
    "effectiveGasPrice": "0x174876e800",
    "from": "one1zksj3evekayy90xt4psrz8h6j2v3hla4qwz4ur",
    "gasUsed": 21000,
    "logs": [],
    "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
    "root": "0x",
    "shardID": 0,
    "status": 1,
    "to": "one1eenp9ujcrmyaq22ef6jrpry2k97tjz4xs6ppcf",
    "transactionHash": "0x54e5a487016f05fa402b314c1e1aac397163863842c1914c3a3511a77e0cc838",
    "transactionIndex": 0
  }
}

sophoah · 2025-01-13T06:53:51Z

hey @GheisMohammadi please review/approve this PR

sophoah · 2025-01-13T07:50:56Z

@Frozen thanks hmyv2 looks good now

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "blockHash": "0x896cfee82ef9542433cdf392548ce519bb7d531eec9d018f26b39e29f0e055b0",
    "blockNumber": 9,
    "contractAddress": "0x0000000000000000000000000000000000000000",
    "cumulativeGasUsed": 21000,
    "effectiveGasPrice": 100000000000,
    "from": "one1zksj3evekayy90xt4psrz8h6j2v3hla4qwz4ur",
    "gasUsed": 21000,
    "logs": [],
    "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
    "root": "0x",
    "shardID": 0,
    "status": 1,
    "to": "one19zzwsxr0uf2fe34y8qkadek2v0eh6h5mg2deg6",
    "transactionHash": "0x6ce7fd454c5c3e642a4573bd684f28acaf5f5478dddf56f1ec64c8808b57190a",
    "transactionIndex": 0
  }
}

.travis.yml

sophoah · 2025-01-13T08:00:35Z

hey @sunwavesun can you help review/approve the PR ?

sophoah · 2025-01-17T07:02:48Z

@mur-me we talked about the ci test failure in our previous meeting

I've confirmed that our localnet is getting the effectiveGasPrice from transactionReceipt RPC : https://github.com/harmony-one/go-sdk/blob/master/cmd/subcommands/staking.go#L174 so the current branch on harmony-test is wrong like you said.

mur-me · 2025-01-17T13:36:49Z

RPC tests were updated, I'm trying to rerun them

Link to the harmony-test PR - harmony-one/harmony-test#34

Frozen self-assigned this Sep 17, 2024

Frozen force-pushed the feature/effective-gas-price branch from 9ddc0cd to c6faf4c Compare September 17, 2024 20:44

Frozen marked this pull request as ready for review September 20, 2024 16:43

Frozen force-pushed the feature/effective-gas-price branch from 0bb2b32 to e3a5dd6 Compare September 20, 2024 17:40

sophoah reviewed Sep 23, 2024

View reviewed changes

rpc/harmony/v2/types.go Outdated Show resolved Hide resolved

Frozen force-pushed the feature/effective-gas-price branch 2 times, most recently from a230a06 to af35364 Compare September 27, 2024 21:10

sophoah requested a review from GheisMohammadi September 30, 2024 07:33

Frozen force-pushed the feature/effective-gas-price branch from af35364 to 150f2f5 Compare October 14, 2024 22:22

Frozen added 11 commits January 8, 2025 21:39

Effective gas price. WIP

efd6625

Effective gas price.

6887f0e

Added test is effective gas price is optional.

b910f7c

Added code to state processor.

e0d8ca9

Added tests for rlp empty EffectiveGasPrice.

fba8f9e

Removed commented block code.

49bc99b

Run tests against branch feature/effective-gas-price

af03638

Added effectiveGasPrice to TxReceipt.

0711d44

Added effectiveGasPrice to eth epi.

a40e6eb

effectiveGasPrice in hex

d97d413

Effective gas price to staking transaction.

d308ae9

Frozen force-pushed the feature/effective-gas-price branch from 302422e to d308ae9 Compare January 9, 2025 03:49

uint64 for effectiveGasPrice in V2

f9cfd2e

sophoah reviewed Jan 13, 2025

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

Merge branch 'dev' into feature/effective-gas-price

10be052

sunwavesun approved these changes Jan 17, 2025

View reviewed changes

sophoah mentioned this pull request Jan 17, 2025

Placeholder PR for Release v2025.0.0 #4831

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Effective gas price #4759

Effective gas price #4759

Frozen commented Sep 17, 2024 •

edited

Loading

sophoah commented Sep 23, 2024 •

edited

Loading

sophoah commented Sep 30, 2024

Frozen commented Oct 16, 2024 •

edited

Loading

sophoah commented Oct 17, 2024

ChiTimesChi commented Jan 8, 2025

Frozen commented Jan 8, 2025 •

edited

Loading

sophoah commented Jan 10, 2025

sophoah commented Jan 13, 2025

sophoah commented Jan 13, 2025

sophoah commented Jan 13, 2025

sophoah commented Jan 17, 2025

mur-me commented Jan 17, 2025 •

edited

Loading

Effective gas price #4759

Are you sure you want to change the base?

Effective gas price #4759

Conversation

Frozen commented Sep 17, 2024 • edited Loading

sophoah commented Sep 23, 2024 • edited Loading

sophoah commented Sep 30, 2024

Frozen commented Oct 16, 2024 • edited Loading

sophoah commented Oct 17, 2024

ChiTimesChi commented Jan 8, 2025

Frozen commented Jan 8, 2025 • edited Loading

sophoah commented Jan 10, 2025

sophoah commented Jan 13, 2025

sophoah commented Jan 13, 2025

sophoah commented Jan 13, 2025

sophoah commented Jan 17, 2025

mur-me commented Jan 17, 2025 • edited Loading

Frozen commented Sep 17, 2024 •

edited

Loading

sophoah commented Sep 23, 2024 •

edited

Loading

Frozen commented Oct 16, 2024 •

edited

Loading

Frozen commented Jan 8, 2025 •

edited

Loading

mur-me commented Jan 17, 2025 •

edited

Loading