-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor #10
base: main
Are you sure you want to change the base?
refactor #10
Conversation
Hi Haotian, I have been using ctrl sac these days, so I refactored the state-based algorithms by the way. I tried to keep the implementations identical to the original ones, but I am not 100% sure whether their performances are good. It would be great if you can have a look at them, especially ctrl_sac and speder_sac, thanks! |
Thank you for the great effort! I am taking a look at the implementation. |
Benchmarked:
Benchmark Ongoing:
Not implemented:
|
Hi Haotian, I drafted this pull request to better illustrate the structural changes. I think there are some things we can do:
spectralrl
, to manage the codes and to distribute the codes conveniently with pypi.hydra
for argument parsing, instead ofargparse
, since different algorithms require different sets of argumentsCurrently, I have partially completed 1-3 (see
spectral/
andexamples/main_visual.py
). I am still testing the image-based algorithms to make sure they behave in the same way as the original implementations. Could you help with refactoring the state-based algorithms if possible?