PullDrawer-v1 Env with reward function and motion planner #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge conflict resolved
merge newer commits
resolve merge conflicts
StoneT2000
requested changes
Dec 26, 2024
There was a problem hiding this comment.
Main things need example video task, document it as a python docstring (see other tasks), and also can you update the code generation scripts in scripts/data_generation with the new motion planner code?
And for PPO can you give an example script that works? I will run it on my 4090 to record to wandb.
| from mani_skill.utils.building import actors | ||
|
|
||
| @register_env("PullDrawer-v1", max_episode_steps=200) | ||
| class PullDrawerEnv(BaseEnv): |
There was a problem hiding this comment.
we recently updated how we document tasks/environments. It is nearly completely automatically generated now. Can you follow the documentation style of e.g. PushCube? Moreover can you save an example video with ray tracing of this task and put it in the folder with the others?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new env: PullDrawer-v1 along with the dense reward and motion planner