Code

Fast atan and atan2 functions.#8388

Code

Open

mcourteaux wants to merge 23 commits intohalide:mainhalide/Halide:mainfrom mcourteaux:fast-atanmcourteaux/Halide:fast-atanCopy head branch name to clipboard

+847-8

Commits

Commits on Nov 11, 2024

• Fast vectorizable atan and atan2 functions.

  mcourteaux

  committed
  cc3ef99

  Copy full SHA for cc3ef99

• Default to not using fast atan versions if on CUDA.

  mcourteaux

  committed
  56cab26

  Copy full SHA for 56cab26

• Finished fast atan/atan2 functions and tests.

  mcourteaux

  committed
  59e6d35

  Copy full SHA for 59e6d35

• Correct attribution.

  mcourteaux

  committed
  7c64aa2

  Copy full SHA for 7c64aa2

• Clang-format

  mcourteaux

  committed
  020e966

  Copy full SHA for 020e966

• Weird WebAssembly limits...

  mcourteaux

  committed
  cde21ca

  Copy full SHA for cde21ca

• Small improvements to the optimization script.

  mcourteaux

  committed
  0881fdd

  Copy full SHA for 0881fdd

• Polynomial optimization for log, exp, sin, cos with correct ranges.

  mcourteaux

  committed
  73816c6

  Copy full SHA for 73816c6

• Improve fast atan performance tests for GPU.

  mcourteaux

  committed
  a75d68b

  Copy full SHA for a75d68b

• Bugfix fast_atan approximation. Fix correctness test to exceed the range (-1, 1) to test (-4, 4). Cleanup code/comments. Test performance for all approximations.

  mcourteaux

  committed
  1c0f794

  Copy full SHA for 1c0f794

• Cleanup

  mcourteaux

  committed
  5d32551

  Copy full SHA for 5d32551

• Enum class instead of enum for ApproximationPrecision.

  mcourteaux

  committed
  11c5209

  Copy full SHA for 11c5209

• Weird Metal limits. There should be a better way...

  mcourteaux

  committed
  f3b9d8f

  Copy full SHA for f3b9d8f

• Skip test for WebGPU.

  mcourteaux

  committed
  1a92308

  Copy full SHA for 1a92308

• Fast atan/atan2 polynomials reoptimized. New optimization strategy: ULP.

  mcourteaux

  committed
  775061a

  Copy full SHA for 775061a

• Feedback Steven.

  mcourteaux

  committed
  6cb4fac

  Copy full SHA for 6cb4fac

• More comments and test mantissa error.

  mcourteaux

  committed
  e9823c1

  Copy full SHA for e9823c1

• Do not error when testing arctan performance on Metal / WebGPU.

  mcourteaux

  committed
  3ced523

  Copy full SHA for 3ced523

• Rework precision specification. Generalize towards using this for other functions.

  mcourteaux

  committed
  b35f7fa

  Copy full SHA for b35f7fa

• Clang-format.

  mcourteaux

  committed
  c004f72

  Copy full SHA for c004f72

• Fix makefile and clang-tidy.

  mcourteaux

  committed
  34a5ff9

  Copy full SHA for 34a5ff9

Commits on Nov 12, 2024

• Fix incorrect approximation selection when required precision is not available.

  mcourteaux

  committed
  9408c93

  Copy full SHA for 9408c93

Commits on Dec 3, 2024

• Feedback from Steven.

  mcourteaux

  committed
  8efe869

  Copy full SHA for 8efe869