-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Make memory
follow mill module structure
#14773
Open
ehigham
wants to merge
2
commits into
ps-12-17-move_mill_modules_into_subdirectory
Choose a base branch
from
ehigham/memory-mill-module
base: ps-12-17-move_mill_modules_into_subdirectory
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[query] Make memory
follow mill module structure
#14773
ehigham
wants to merge
2
commits into
ps-12-17-move_mill_modules_into_subdirectory
from
ehigham/memory-mill-module
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
Merged
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
December 18, 2024 16:05
1147b2b
to
c291b9c
Compare
patrick-schultz
force-pushed
the
ehigham/memory-mill-module
branch
from
December 18, 2024 16:05
b506eb7
to
2e1deb3
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
December 18, 2024 17:45
c291b9c
to
51abd7d
Compare
patrick-schultz
force-pushed
the
ehigham/memory-mill-module
branch
from
December 18, 2024 17:45
2e1deb3
to
3b20487
Compare
ehigham
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
December 18, 2024 18:19
51abd7d
to
2b3a4af
Compare
ehigham
force-pushed
the
ehigham/memory-mill-module
branch
from
December 18, 2024 18:19
3b20487
to
0b47eab
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
December 18, 2024 18:32
2b3a4af
to
a459164
Compare
patrick-schultz
force-pushed
the
ehigham/memory-mill-module
branch
from
December 18, 2024 18:32
0b47eab
to
edc5067
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
December 18, 2024 19:19
a459164
to
a40fa7d
Compare
patrick-schultz
force-pushed
the
ehigham/memory-mill-module
branch
from
December 18, 2024 19:30
edc5067
to
0463555
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
6 times, most recently
from
January 3, 2025 15:59
6ce5016
to
e793b6d
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
3 times, most recently
from
January 7, 2025 13:54
c066895
to
0cbe834
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
3 times, most recently
from
January 9, 2025 19:59
c54210d
to
e2bdc83
Compare
This was referenced Jan 9, 2025
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
2 times, most recently
from
January 10, 2025 19:38
c2603da
to
005d23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Reorganizes the Mill build configuration by removing redundant SbtModule inheritance and relocates Memory.java files into a dedicated memory module directory structure.
Security Assessment
This change has no security impact
Impact Description
Low-level build configuration changes and file reorganization with no functional modifications to the codebase.