Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Improve error handling and job tracking in ServiceBackend #14751

Open
wants to merge 3 commits into
base: qob-fast-cancel
Choose a base branch
from
Open

[query] Improve error handling and job tracking in ServiceBackend #14751

wants to merge 3 commits into from
+321 −68

Conversation

grohli
Copy link
Contributor

@grohli grohli commented Nov 5, 2024 •
edited
Loading

Change Description

  • Added ability to check job status in individual jobs in a JobGroup
  • Cancel JobGroup if any jobs in the partition fail
  • Added test functionality for detecting cancelled, failed jobs
  • Query batch for which jobs have failed within a JobGroup, rather than go through every job in the group.

Security Assessment

Delete all except the correct answer:

  • This change has no security impact

Impact Description

Mainly just code for testing, nothing security related

(Reviewers: please confirm the security impact before approving)

@grohli grohli mentioned this pull request Nov 5, 2024
Open
@grohli Graphite App
Copy link
Contributor Author

grohli commented Nov 5, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@grohli grohli changed the title Added ability to check job status of individual job, made associated tests [batch] Improve error handling and job tracking in ServiceBackend Nov 5, 2024
@grohli grohli changed the title [batch] Improve error handling and job tracking in ServiceBackend [query] Improve error handling and job tracking in ServiceBackend Nov 5, 2024
@grohli grohli marked this pull request as ready for review November 5, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehigham ehigham ehigham requested changes

@chrisvittal chrisvittal Awaiting requested review from chrisvittal

@patrick-schultz patrick-schultz Awaiting requested review from patrick-schultz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grohli @ehigham