Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds usage examples #9

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Adds usage examples #9

wants to merge 13 commits into from

Conversation

nipsn
Copy link
Contributor

@nipsn nipsn commented Mar 15, 2024

Depends on /pull/7

Currently contains an example for simple email detection

Closes #4

@nipsn nipsn requested a review from neutropolis March 15, 2024 13:51
@nipsn nipsn self-assigned this Mar 15, 2024
@nipsn nipsn force-pushed the feature/examples branch 4 times, most recently from 41f0199 to 869ef00 Compare March 21, 2024 13:49
@nipsn nipsn force-pushed the feature/examples branch from 869ef00 to aaeaf42 Compare March 21, 2024 13:50
@neutropolis
Copy link
Member

We need to change the format of this contribution, since we don't want to supply the motivation as a q file. Instead, we should have an example directory with notebooks or markdowns files, containing this material and complementing it with textual explanations. The README file will probably contain one of those examples.

@nipsn
Copy link
Contributor Author

nipsn commented Mar 27, 2024

Sounds good to me. I was actually doing the development on notebooks and then copy-pasting into a q file, so this shouldn't take too long.

I'll try to make these changes as soon as I have some time to dedicate to it

@nipsn nipsn force-pushed the feature/examples branch from ae0b4b1 to aac67d4 Compare April 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor some function names
2 participants