Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #496 Installation on Eclipse 2024-09 #497

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fixed issue #496 Installation on Eclipse 2024-09 #497

merged 1 commit into from
Sep 17, 2024

Conversation

keinhaar
Copy link
Contributor

  • Removed the dependency on org.eclipse.jetty.servlet, because it seems to be unnecessary.
  • Added gwt 2.10.1 and gwt 2.11.0 to the .gitignore file

@keinhaar
Fixed issue gwt-plugins#496 Installation on Eclipse 2024-09
03d2148 
- Removed the dependency on org.eclipse.jetty.servlet, because it seems
to be unnecessary.
- Added gwt 2.10.1 and gwt 2.11.0 to the .gitignore file
@keinhaar
Copy link
Contributor Author

@protoism would you please check this?

@protoism
Copy link
Contributor

Sooner or later we'll have to re-add jetty, as GWT SDK, reasonably, should not be used to serve the application.
But compatibility with 2024-09 is more important...

@protoism protoism self-requested a review September 17, 2024 12:09
protoism
protoism approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@protoism protoism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it's ok....

@protoism protoism merged commit 955bf65 into gwt-plugins:main Sep 17, 2024
1 check passed
@keinhaar keinhaar deleted the eclipse-2024-09 branch September 17, 2024 19:11
@keinhaar
Copy link
Contributor Author

Sooner or later we'll have to re-add jetty, as GWT SDK, reasonably, should not be used to serve the application. But compatibility with 2024-09 is more important...

i do not understand. i did not remove jetty dependency. only jetty.servlet which is no longer present in jetty 12. the devmode with jetty still works normally.

keinhaar added a commit to keinhaar/gwt-eclipse-plugin that referenced this pull request Dec 1, 2024
@keinhaar
Fixed issue gwt-plugins#496 Installation on Eclipse 2024-09 (gwt-plug…
605b4b2 
…ins#497)

- Removed the dependency on org.eclipse.jetty.servlet, because it seems
to be unnecessary.
- Added gwt 2.10.1 and gwt 2.11.0 to the .gitignore file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protoism protoism protoism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keinhaar @protoism