Use RegexAst::Literal instead of const field on strings for fast enums #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmoskal kind of messed up the base of this pr as I had to merge main back into yours |
hudson-ai
commented
Dec 23, 2024
| min_length: 0, | ||
| max_length: None, | ||
| regex: Some(RegexAst::Literal(s)), | ||
| } => ®ex_syntax::escape(&serde_json::to_string(s).unwrap()), |
There was a problem hiding this comment.
This is the bit that makes it a bit tricky to do this for general string regexes -- json quoting
There was a problem hiding this comment.
I'll add AST node to escape. Shouldn't be hard.
|
This takes the compile time of the schema in the linked issue #98 from 162ms to 44ms on my machine (still fairly slow, I suppose). Bundling everything into a lexeme probably really speeds up mask computation too :) |
mmoskal
approved these changes
Dec 24, 2024
Closed
|
Closes #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.