Add a tool-versions-folder param to specify non-standard .tool-versions locations
#2
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions` locations `guardian/setup-scala` has assumed that the `.tool-versions` file will always be in the current working directory, but that's not always the case - eg: guardian/janus#4527 One option to get around that, I think, would be to set `working-directory:` when invoking `guardian/setup-scala`: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsworking-directory ...but maybe allowing specific-configuration of where this _particular file_ is located is more elegant or future-proof maybe?
rtyley
force-pushed
the
support-specifying-path-to-tool-versions
branch
from
80131e4 to
88fc937
Compare
davidfurey
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guardian/setup-scalahas assumed that the.tool-versionsfile will always be in the current working directory, but that's not always the case - eg: https://github.com/guardian/janus/pull/4527One option to get around that, I think, would be to set
working-directory:when invokingguardian/setup-scala:...but maybe allowing specific-configuration of where this specific file is located is more expressive or future-proof?