Skip to content

Commit

Permalink
Removed useless commented things
Browse files Browse the repository at this point in the history
  • Loading branch information
patricklafrance committed Oct 26, 2023
1 parent 5d24072 commit c45cadc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ class DummyRuntime extends AbstractRuntime<unknown, unknown> {

const runtime = new DummyRuntime();

/*
- when local module deferred registrations and remote module deferred registrations are registered and only the local module deferred registrations are completed, return false
- when local module deferred registrations and remote module deferred registrations are registered and only the remote module deferred registrations are completed, return false
*/

test("when no modules are registered, return false", async () => {
const localModuleRegistry = new LocalModuleRegistry();

Expand Down
35 changes: 0 additions & 35 deletions samples/endpoints/shell/src/AppRouter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,41 +6,6 @@ import axios from "axios";
import { useEffect, useMemo, useState } from "react";
import { Outlet, RouterProvider, createBrowserRouter, useLocation } from "react-router-dom";

/*
AppRouter
- loader
- onFetchInitialData -> (doit passer un "signal")
- onFetchSession
- onFetchProtectedData -> Si fournie, est inclus dans le isReady - (doit passer un "signal")
- waitForMsw
- rootRoute - Si fournis est-ce le parent de la root route du AppRouter?
- routerProviderOptions
*/

/*
import { AppRouter as SquideAppRouter } from "@squide/shell";
export function AppRouter() {
const [subscription, setSubscription] = useState<Subscription>();
onFetchProtectedData() {
....
}
return (
<TelemetryContext.Provider value={}>
<SubcriptionContext.Provider value={subscription}
<SquideAppRouter onFetchProtectedData={onFetchProtectedData} />
</SubcriptionContext.Provider >
</TelemetryContext.Provider value={}>
)
}
*/

async function fetchPublicData(
setFeatureFlags: (featureFlags: FeatureFlags) => void,
logger: Logger
Expand Down

0 comments on commit c45cadc

Please sign in to comment.