-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make empty generated source files descriptive #2151
Changes from 4 commits
c2712f0
a968d3c
ec55cd5
8385afb
0878398
e4faa41
11f13a1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,200 @@ | ||||||
/* | ||||||
* Copyright 2024, gRPC Authors All rights reserved. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* | ||||||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
* you may not use this file except in compliance with the License. | ||||||
* You may obtain a copy of the License at | ||||||
* | ||||||
* http://www.apache.org/licenses/LICENSE-2.0 | ||||||
* | ||||||
* Unless required by applicable law or agreed to in writing, software | ||||||
* distributed under the License is distributed on an "AS IS" BASIS, | ||||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
* See the License for the specific language governing permissions and | ||||||
* limitations under the License. | ||||||
*/ | ||||||
|
||||||
import Testing | ||||||
|
||||||
@testable import GRPCCodeGen | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can use a regular import if you use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🙏 will do. |
||||||
|
||||||
extension StructuredSwiftTests { | ||||||
@Suite("Import") | ||||||
struct Import { | ||||||
static let translator = IDLToStructuredSwiftTranslator() | ||||||
|
||||||
static let allAccessLevels: [SourceGenerator.Config.AccessLevel] = [ | ||||||
.internal, .public, .package, | ||||||
] | ||||||
|
||||||
@Test( | ||||||
"import rendering", | ||||||
arguments: allAccessLevels | ||||||
) | ||||||
func imports(accessLevel: SourceGenerator.Config.AccessLevel) throws { | ||||||
var dependencies = [Dependency]() | ||||||
dependencies.append(Dependency(module: "Foo", accessLevel: .public)) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .typealias, name: "Bar"), | ||||||
module: "Foo", | ||||||
accessLevel: .internal | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .struct, name: "Baz"), | ||||||
module: "Foo", | ||||||
accessLevel: .package | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .class, name: "Bac"), | ||||||
module: "Foo", | ||||||
accessLevel: .package | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .enum, name: "Bap"), | ||||||
module: "Foo", | ||||||
accessLevel: .package | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .protocol, name: "Bat"), | ||||||
module: "Foo", | ||||||
accessLevel: .package | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .let, name: "Baq"), | ||||||
module: "Foo", | ||||||
accessLevel: .package | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .var, name: "Bag"), | ||||||
module: "Foo", | ||||||
accessLevel: .package | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .func, name: "Bak"), | ||||||
module: "Foo", | ||||||
accessLevel: .package | ||||||
) | ||||||
) | ||||||
|
||||||
let expected = | ||||||
""" | ||||||
\(accessLevel.level) import GRPCCore | ||||||
public import Foo | ||||||
internal import typealias Foo.Bar | ||||||
package import struct Foo.Baz | ||||||
package import class Foo.Bac | ||||||
package import enum Foo.Bap | ||||||
package import protocol Foo.Bat | ||||||
package import let Foo.Baq | ||||||
package import var Foo.Bag | ||||||
package import func Foo.Bak | ||||||
""" | ||||||
|
||||||
let imports = try StructuredSwiftTests.Import.translator.makeImports( | ||||||
dependencies: dependencies, | ||||||
accessLevel: accessLevel, | ||||||
accessLevelOnImports: true | ||||||
) | ||||||
|
||||||
#expect(render(imports) == expected) | ||||||
} | ||||||
|
||||||
@Test( | ||||||
"preconcurrency import rendering" | ||||||
) | ||||||
func preconcurrencyImports() throws { | ||||||
var dependencies = [Dependency]() | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
module: "Foo", | ||||||
preconcurrency: .required, | ||||||
accessLevel: .internal | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .enum, name: "Bar"), | ||||||
module: "Foo", | ||||||
preconcurrency: .required, | ||||||
accessLevel: .internal | ||||||
) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
module: "Baz", | ||||||
preconcurrency: .requiredOnOS(["Deq", "Der"]), | ||||||
accessLevel: .internal | ||||||
) | ||||||
) | ||||||
|
||||||
let expected = | ||||||
""" | ||||||
public import GRPCCore | ||||||
@preconcurrency internal import Foo | ||||||
@preconcurrency internal import enum Foo.Bar | ||||||
#if os(Deq) || os(Der) | ||||||
@preconcurrency internal import Baz | ||||||
#else | ||||||
internal import Baz | ||||||
#endif | ||||||
""" | ||||||
|
||||||
let imports = try StructuredSwiftTests.Import.translator.makeImports( | ||||||
dependencies: dependencies, | ||||||
accessLevel: .public, | ||||||
accessLevelOnImports: true | ||||||
) | ||||||
|
||||||
#expect(render(imports) == expected) | ||||||
} | ||||||
|
||||||
@Test( | ||||||
"SPI import rendering" | ||||||
) | ||||||
func spiImports() throws { | ||||||
var dependencies = [Dependency]() | ||||||
dependencies.append( | ||||||
Dependency(module: "Foo", spi: "Secret", accessLevel: .internal) | ||||||
) | ||||||
dependencies.append( | ||||||
Dependency( | ||||||
item: .init(kind: .enum, name: "Bar"), | ||||||
module: "Foo", | ||||||
spi: "Secret", | ||||||
accessLevel: .internal | ||||||
) | ||||||
) | ||||||
|
||||||
let expected = | ||||||
""" | ||||||
public import GRPCCore | ||||||
@_spi(Secret) internal import Foo | ||||||
@_spi(Secret) internal import enum Foo.Bar | ||||||
""" | ||||||
|
||||||
let imports = try StructuredSwiftTests.Import.translator.makeImports( | ||||||
dependencies: dependencies, | ||||||
accessLevel: .public, | ||||||
accessLevelOnImports: true | ||||||
) | ||||||
|
||||||
#expect(render(imports) == expected) | ||||||
} | ||||||
|
||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package
is your friend here