Abidjan Creator #154
Merged
Abidjan Creator #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite tag as agency_url
…ame if the route has no route_short_name (route number). Useful for the gbaka, because we keep the mode in the route_long_name.
|
Hey ! any thought about this PR ? Merry Christmas to all the bus mappers in the world 🎅 🚏 🗺️ |
|
Looks good! I didn't look too much into the custom trips creator. Are you finished? or are you still working on it? Can you squash the commits to a single one? Maybe with the two of you, one with |
|
Yes, we are finished here. You can use the "squash and merge" github button |
pantierra
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here come the first version of the Abidjan (Ivory Coast) creator 🎉
It uses
operatorandoperator:websitetags from OSM relations to set up the GTFSagencies.It generates a GTFS with a frequencies.txt file and uses the logic described in #146:
opening_hours,intervalandinterval:conditionaltags on OSM relations are used to set up the schedule datadurationtag is used to interpolate the time of travel between stops of each tripWe will use it in Abidjan for a while (our data collection is still ongoing) and if everything works as expected, we will go on with the issues #146 and #118, and move this logic to the default creator.
Some tests comes along the creator.