Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Frameshift VEP plugin instead of Downstream plugin for frameshift peptide sequence predictions #634

Merged
merged 8 commits into from
Jan 26, 2021

Conversation

susannasiebert
Copy link
Contributor

@susannasiebert susannasiebert commented Jan 15, 2021

This PR removes the dependency on the VEP Downstream plugin and instead uses a custom Frameshift plugin which annotates frameshift variants with the full mutated peptide sequence, instead of only the mutated tail downstream of the mutation. This fixes error when using VEP version 100 and above with the Downstream plugin caused by the downstream peptide sequence starting at a non-deterministic position after the mutation, probably due to left-shifting.

The protein length change, which previously came from the Downstream plugin, is now calculated by comparing the length of the mutated frameshift peptide sequence to the wildtype peptide sequence (from the Wildtype plugin).

Test data was mostly updated by reannotating the VCFs with VEP 95 with the new Frameshift plugin. For short test VCFs without frameshift sequences, the VCFs were updates manually to fix the CSQ header and entries, since they would be empty for missense and in-frame indels. Some test were removed (i.e. ones that tested that the error for the missing leading wildtype amino acid worked). For the main pVACseq tests, some transcripts included in the test data had changes to the transcript sequence leading to different mutated frameshift predictions. This, in turn, necessitated updates to the mock test data from IEDB and Blast. As a result the filtered epitope list is significantly different from previous tests but the core functionality that is being tested remains the same.

Closes #596 and #576

@susannasiebert susannasiebert merged commit a5d225d into staging Jan 26, 2021
@susannasiebert susannasiebert deleted the frameshift branch January 27, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildtype/Downstream mismatch Compare the downstream amino acid sequences using the shifted start position
1 participant