Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out when attempting to use multithreading on MacOS #1052

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

susannasiebert
Copy link
Contributor

When running any of the pVACtools with multithreading (-t) on MacOS, all but one forked thread will be killed with:

The process has forked and you cannot use this CoreFoundation functionality safely. 
You MUST exec(). Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_
COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.

The pVACtools run will still complete successfully, but all of the prediction calls that were scheduled for killed threads will not be made so a lot of predictions will be missing from the final output.

I tried various workarounds but wasn't able to get it to work. I put in a ticket with pymp-pypi, which is what we use for multithreading. In the meantime, this update will prevent users from running the tools in with multithreading on MacOS.

@susannasiebert susannasiebert merged commit cc994c5 into hotfix Jan 17, 2024
5 of 6 checks passed
@susannasiebert susannasiebert deleted the macos_multithreading branch January 24, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant