Error out when attempting to use multithreading on MacOS #1052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running any of the pVACtools with multithreading (
-t
) on MacOS, all but one forked thread will be killed with:The pVACtools run will still complete successfully, but all of the prediction calls that were scheduled for killed threads will not be made so a lot of predictions will be missing from the final output.
I tried various workarounds but wasn't able to get it to work. I put in a ticket with pymp-pypi, which is what we use for multithreading. In the meantime, this update will prevent users from running the tools in with multithreading on MacOS.