missing_presence_validation: ignore all columns with proper inclusion/exclusion validations #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/exclusion validations
fatkodima
commented
Jan 14, 2025
| @@ -62,7 +59,7 @@ def inclusion_validator_present?(model, column) | |||
| return true if validator_items.is_a?(Proc) | |||
|
|
|||
| validator.is_a?(ActiveModel::Validations::InclusionValidator) && | |||
| validator.attributes.include?(column.name.to_sym) && | |||
| validator.attributes.map(&:to_s).include?(column.name) && | |||
There was a problem hiding this comment.
enum converts attributes to strings, so we need now to check for both strings and symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed, that
missing_presence_validationchecker marksenum ..., validate: trueas offences, even though these are false positives.enumdefinition usesvalidates_inclusion_ofunder the hood, but the checker considers only boolean columns having properinclusion/exclusionvalidations as good. I think, this should be extended to other column types.