Change: Pin codespell version to 2.3.0 (latest release) #783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR pins codespell to the currently latest release (
2.3.0
right now).Why
When running
poetry upgrade troubadix
, pipx won't upgrade the dependencies as long as they still meet the dependency requirements.This requirement is currently:
In case e.g. codespell 2.3.1 is release we updated pyproject.toml / poetry.lock, an end-user still won't necessarily have the same codespell version.
We can reproduce this behavior by installing a non-latest Troubadix, then manually installing a non-latest version of codespell in the venv. After upgrading Troubadix, codespell is still at the older release, because it still meets the dependency requirement:
We can fix this by always explicitly requiring the latest codespell version in pyproject.toml instead of a version range.
After this change the
METADATA
file contains:After that it's still possible to manually inject a lower codespell version (I guess this is on purpose), however
pipx upgrade troubadix
will enforce the version specified inMETADATA
again.References
Checklist