Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Drop mention of obsolete dependency on xml-twig-tools in Dockerfile #2321

Closed
wants to merge 1 commit into from

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Nov 13, 2024

What

In #2142 the dependency itself has been dropped but it was missed to remove the relevant comment as well.

Why

Don't mention an unnecessary dependency

References

@cfi-gb cfi-gb requested review from a team as code owners November 13, 2024 09:31
Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@cfi-gb cfi-gb changed the title Docs: Drop mention of obsolete dependency on xml-tw/ig-tools in Dockerfile Docs: Drop mention of obsolete dependency on xml-twig-tools in Dockerfile Nov 13, 2024
@cfi-gb cfi-gb changed the title Docs: Drop mention of obsolete dependency on xml-twig-tools in Dockerfile Doc: Drop mention of obsolete dependency on xml-twig-tools in Dockerfile Nov 13, 2024
@y0urself
Copy link
Member

y0urself commented Jan 3, 2025

You can not use forks @cfi-gb, this is since over 2 years. Please recreate your PR with a feature branch.

bjoernricks added a commit that referenced this pull request Jan 3, 2025
xml split tool from xml-twig-tools packages isn't used anymore.
Therefore the comment is obsolete.

Replaces #2321
bjoernricks added a commit that referenced this pull request Jan 3, 2025
xml split tool from xml-twig-tools packages isn't used anymore.
Therefore the comment is obsolete.

Replaces #2321
@bjoernricks bjoernricks closed this Jan 3, 2025
auto-merge was automatically disabled January 3, 2025 11:15

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants