Change: GMP doc: remove option timezone from GET_RESULTS #2168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the
timezone
option from GET_RESULTS in the GMP doc.Why
There is no such option. For example:
Note the +02:00 on the time. It is the same without the option:
References
Looks like Timo accidentally added this in 587584b, probably because GET_RESULTS is very similar to GET_REPORTS. However, GET_REPORTS is calling
manage_report_filter_controls
(in print_report_xml_start) with a return zone argument, whereas GET_RESULTS is callingmanage_report_filter_controls
(in handle_get_results) with aNULL
zone argument.So GET_REPORTS accepts the timezone option, for example:
Note the Z in the time.