Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish the artifact in SonaType or other Maven artifactory #5 #51

Merged
merged 76 commits into from
Jul 8, 2024
Merged

Publish the artifact in SonaType or other Maven artifactory #5 #51

merged 76 commits into from
Jul 8, 2024

Conversation

BartekGravity
Copy link
Contributor 

* Provide a deployment pipeline
* Prepare the artifact for SonaType release

@BartekGravity
Publish the artifact in SonaType or other Maven artifactory #5
13fc954 
    * Provide a deployment pipeline
    * Prepare the artifact for SonaType release
@jbibro jbibro had a problem deploying to Deployment_manual June 24, 2024 09:43 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 10:32 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 10:44 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 11:28 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 12:32 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 12:54 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 13:13 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 13:15 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 25, 2024 13:22 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 27, 2024 10:53 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 08:18 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 08:41 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 08:43 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 08:49 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 08:52 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 09:00 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 09:01 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 09:04 — with GitHub Actions Failure
@jbibro jbibro had a problem deploying to Deployment_manual June 28, 2024 09:10 — with GitHub Actions Failure
MateuszGravity9
MateuszGravity9 reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@MateuszGravity9 MateuszGravity9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming changes - just a proposal, it seems more readable to me that way but I am not insisting

.github/workflows/maven.yml Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
BartekGravity
BartekGravity commented Jun 28, 2024
View reviewed changes
Copy link
Contributor Author

@BartekGravity BartekGravity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

MateuszGravity9
MateuszGravity9 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@MateuszGravity9 MateuszGravity9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbibro jbibro merged commit ba4292b into main Jul 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbibro jbibro jbibro left review comments

@MateuszGravity9 MateuszGravity9 MateuszGravity9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BartekGravity @jbibro @MateuszGravity9