Add template for client tools auto-update download url #51210
Merged
+139
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakeURL moved to common function to be general for both, agent and client tools
vapopov
force-pushed
the
vapopov/client-tools-update-uri-template
branch
from
feea920 to
2f06e54
Compare
|
@sclevine I've changed to use |
hugoShaka
approved these changes
Jan 23, 2025
sclevine
approved these changes
Jan 23, 2025
|
@timothyb89 don't you mind also review this PR, need one more approval to merge |
timothyb89
approved these changes
Jan 24, 2025
sclevine
reviewed
Jan 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vapopov
added a commit
that referenced
this pull request
Jan 24, 2025
* Add templates for client tools auto-update download url * Change to base url setting by env MakeURL moved to common function to be general for both, agent and client tools * Add godoc for common function and constant for default package * Use flags and version arguments instead of revision * Move base url env to shared constant
vapopov
added a commit
that referenced
this pull request
Jan 24, 2025
* Add templates for client tools auto-update download url * Change to base url setting by env MakeURL moved to common function to be general for both, agent and client tools * Add godoc for common function and constant for default package * Use flags and version arguments instead of revision * Move base url env to shared constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR added templating for Teleport download package URL to use general function for both client-tools and agent managed updates, where
BaseURLparameter might be overridden by environment variable.Default template:
BaseURLmight be overridden byTELEPORT_CDN_BASE_URLenvironment valueChangelog: Added support for customizing the base URL for downloading Teleport packages used in client tools managed updates