[v15] Add reason and invited fields to SessionStartEvent #51177
Merged
+1,113
−990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
changed the title
rosstimothy
commented
Jan 17, 2025
| @@ -434,6 +435,7 @@ func newKubeExecCommand(parent *kingpin.CmdClause) *kubeExecCommand { | |||
| } | |||
|
|
|||
| c.Flag("container", "Container name. If omitted, use the kubectl.kubernetes.io/default-container annotation for selecting the container to be attached or the first container in the pod will be chosen").Short('c').StringVar(&c.container) | |||
| c.Flag("kube-namespace", "Configure the default Kubernetes namespace.").Short('n').StringVar(&c.namespace) | |||
There was a problem hiding this comment.
Note: the namespace flag is intentionally omitted since #51076 will not be backported.
In addition to adding the new fields and populating them, this also updates tsh kube exec to include a --kube-namespace flag similar to tsh kube login to make the command easier and more intuitive to use. Closes #51019.
rosstimothy
force-pushed
the
tross/backport-51070/v15
branch
from
cbb0e56 to
6da90c9
Compare
github-actions
bot
added
kubernetes-access
size/sm
tsh
tigrato
approved these changes
Jan 17, 2025
Tener
approved these changes
Jan 20, 2025
public-teleport-github-review-bot
bot
removed the request for review
from r0mant
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #51070 to branch/v15
Changelog: Include invited and reason fields in SessionStartEvents
Changelog: Add a flag to tsh kube exec to allow specifying the namespace outside of the Kubernetes context