Only apply dynamic AWS settings to dynamic AWS dbs #50970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
aws
greedy52
approved these changes
Jan 13, 2025
Dynamic database resource matchers can include AWS settings to assume an AWS IAM role when they match a database. The settings should only be applied to dynamic AWS databases. The db service will no longer apply these settings to non-AWS databases. It will also no longer apply these settings to databases discovered by the legacy cloud watchers in db_service.aws - the cloud watchers have an assume_role_arn setting that should not be overridden by dynamic database matcher settings.
GavinFrazar
force-pushed
the
gavinfrazar/fix-db-assume-role-arn
branch
2 times, most recently
from
1be37ec to
13f9f97
Compare
r0mant
approved these changes
Jan 13, 2025
GavinFrazar
force-pushed
the
gavinfrazar/fix-db-assume-role-arn
branch
from
13f9f97 to
d91942d
Compare
|
@GavinFrazar See the table below for backport results.
|
This was referenced Jan 14, 2025
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Only apply dynamic AWS settings to dynamic AWS dbs Dynamic database resource matchers can include AWS settings to assume an AWS IAM role when they match a database. The settings should only be applied to dynamic AWS databases. The db service will no longer apply these settings to non-AWS databases. It will also no longer apply these settings to databases discovered by the legacy cloud watchers in db_service.aws - the cloud watchers have an assume_role_arn setting that should not be overridden by dynamic database matcher settings. * fix reconcilitation race
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed a database service bug where db_service.resources.aws.assume_role_arn settings could affect non-AWS dynamic databases or incorrectly override db_service.aws.assume_role_arn settings.
Dynamic database resource matchers can include AWS settings to assume an AWS IAM role when they match a database.
The settings should only be applied to dynamic AWS databases.
The db service will no longer apply these settings to non-AWS databases.
It will also no longer apply these settings to databases discovered by the legacy cloud watchers in db_service.aws - the cloud watchers have an assume_role_arn setting that should not be overridden by dynamic database matcher settings.