Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database access through WebUI #49979
Database access through WebUI #49979
Changes from 6 commits
f90e7b4
fac876b
cb254d1
941842e
0434d47
02c6997
cd260cb
8423d76
4183439
d1b2af3
5e26237
cb1ac72
e6db769
34df1fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we handle wildcard? if no wildcard, it shouldn't be
Creatable
in my option.isDisabled={dbUserOpts?.length == 1}
will disable if single wildcard?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we have a wildcard, the fields will be empty, and users must type it out.
Setting to disable will prevent them from changing the roles (I'm not sure if this will be desired).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i must have missed it. Where is the logic to remove wildcard from db users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be confusing to users what role selection does.
We should do either or both of the following:
I would also move role selection below database name selection. I might even put database name selection before user selection. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think selecting all roles initially might be better here. We can also always enforce at least one selected (when there are options available).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the wildcard for roles, we don't have enough information to decide when to show this box. This would be a combination of the database having auto-user provisioning enabled and not having DAC configured on their selected roles (correct me if I need to include anything here). So, for now, only showing when the roles are available might not cover all scenarios, but it will work for the most part. WDYT?
Also worth mentioning that currently, the database roles information is not available. The web handler changes will add this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some facts
So for simplicity, we could just leave this part out.
If we want to keep it:
this should be ok, also it's backend's responsibility to make sure the calculation is correct so we don't build more logic in frontend
I think this would be easiest as well.
IMHO not necessary