operator: Support trusted_cluster resources #49920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supersedes UpsertTrustedCluster rpc. V2 performs resource name validation.
- Remove unnecessary ping - Update error messages - Use skipNameValidation consts - Validate cluster name before establishing trust - Do not reveal cluster name in error message - Use BadParameter instead of CompareFailed
1. Run `make manifests`. 2. Run `make -C crdgen update-protos`. 3. Run `make -C crdgen update-snapshot`.
github-actions
bot
requested review from
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
|
🤖 Vercel preview here: https://docs-9489cues6-goteleport.vercel.app/docs |
bernardjkim
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
|
@bernardjkim - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
|
Amplify deployment status
|
espadolini
approved these changes
Jan 8, 2025
hugoShaka
approved these changes
Jan 8, 2025
|
Hey @rosstimothy, would appreciate an admin approval if you have some time. |
rosstimothy
reviewed
Jan 9, 2025
integrations/operator/apis/resources/v1/trusted_cluster_types.go
Outdated
Show resolved
Hide resolved
bernardjkim
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
bernardjkim
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
rosstimothy
reviewed
Jan 10, 2025
integrations/operator/controllers/resources/trusted_clusterv2_controller_test.go
Outdated
Show resolved
Hide resolved
bernardjkim
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
rosstimothy
approved these changes
Jan 10, 2025
public-teleport-github-review-bot
bot
removed request for
mmcallister,
ptgott,
r0mant,
xinding33 and
zmb3
|
@bernardjkim See the table below for backport results.
|
bernardjkim
added a commit
that referenced
this pull request
Jan 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
* operator: Support trusted_cluster resources (#49920) * crdgen * Still using logrus in v17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #22474
Requires #49789
Todo: Write up guide for managing trusted_clusters with the teleport operatorChangelog: Add trusted_cluster support for the teleport operator.